added unique pointer for connection #4718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nibanks
approved these changes
Dec 19, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4718 +/- ##
==========================================
- Coverage 87.21% 86.63% -0.59%
==========================================
Files 56 56
Lines 17363 17363
==========================================
- Hits 15144 15042 -102
- Misses 2219 2321 +102 ☔ View full report in Codecov by Sentry. |
ami-GS
pushed a commit
that referenced
this pull request
Jan 8, 2025
ami-GS
added a commit
that referenced
this pull request
Jan 9, 2025
* added unique pointer for connection (#4718) * Fix priority operation flaky test (#4615) * Sleep longer to flush queue for sure * cleanup environment for each test case * sleep * GetParam instead of sleep * GetParam 50 times * experimental, handshake just before enqueueing stream operations. Locally works for 1000 times * connection start once all operations are queued --------- Co-authored-by: Gaurav Singh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There were several timeouts observed in bvt tests and testmd runs due to connections pointer not returning the registration reference in connectionpriority test. unique_ptr is used for this and the issue is fixed.