Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event Queue Completion Refactor #4732

Merged
merged 24 commits into from
Jan 6, 2025
Merged

Event Queue Completion Refactor #4732

merged 24 commits into from
Jan 6, 2025

Conversation

nibanks
Copy link
Member

@nibanks nibanks commented Jan 1, 2025

Description

Refactors the CxPlat event queue interface to have completions execute callback functions instead of call hardcoded functions with type value.

Testing

Existing CI/CD

Documentation

N/A - Internal (for now)

Copy link

codecov bot commented Jan 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.52%. Comparing base (f16a46b) to head (b899016).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4732      +/-   ##
==========================================
- Coverage   87.20%   86.52%   -0.68%     
==========================================
  Files          56       56              
  Lines       17363    17378      +15     
==========================================
- Hits        15141    15037     -104     
- Misses       2222     2341     +119     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nibanks nibanks marked this pull request as ready for review January 3, 2025 20:24
@nibanks nibanks requested a review from a team as a code owner January 3, 2025 20:24
@nibanks nibanks added the Area: Core Related to the shared, core protocol logic label Jan 3, 2025
ami-GS
ami-GS previously approved these changes Jan 6, 2025
Copy link
Contributor

@ami-GS ami-GS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice change

mtfriesen
mtfriesen previously approved these changes Jan 6, 2025
src/platform/unittest/PlatformTest.cpp Outdated Show resolved Hide resolved
src/platform/unittest/PlatformTest.cpp Outdated Show resolved Hide resolved
src/platform/unittest/PlatformTest.cpp Outdated Show resolved Hide resolved
src/platform/platform_worker.c Outdated Show resolved Hide resolved
@nibanks nibanks dismissed stale reviews from mtfriesen and ami-GS via b899016 January 6, 2025 19:07
@nibanks nibanks enabled auto-merge (squash) January 6, 2025 19:48
@nibanks nibanks merged commit 1f248f9 into main Jan 6, 2025
485 of 487 checks passed
@nibanks nibanks deleted the event-completion-refactor branch January 6, 2025 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Core Related to the shared, core protocol logic
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants