Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add schannel feature #4735

Merged
merged 1 commit into from
Jan 3, 2025
Merged

Conversation

masa-koz
Copy link
Contributor

@masa-koz masa-koz commented Jan 3, 2025

Description

This pull request introduces support for the schannel feature and updates the build configuration accordingly. The most important changes include modifying the GitHub Actions workflow, updating the Cargo.toml file, and adjusting the build script to conditionally define the TLS library.

Support for schannel feature:

  • .github/workflows/cargo.yml: Expanded the features matrix to include --features schannel and --features schannel,static, and excluded incompatible combinations for certain operating systems.
  • Cargo.toml: Added a new feature named schannel to the features list.

Build configuration adjustments:

  • scripts/build.rs: Modified the build script to conditionally define the QUIC_TLS library based on the presence of the schannel feature, defaulting to openssl if not specified.

Testing

  • cargo test --features schannel
  • cargo test --features schannel,static

Documentation

TBD

@masa-koz masa-koz requested a review from a team as a code owner January 3, 2025 12:30
@nibanks nibanks added Area: Build Language: Rust Related to the Rust interop layer labels Jan 3, 2025
Copy link

codecov bot commented Jan 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.68%. Comparing base (f16a46b) to head (7d7b034).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4735      +/-   ##
==========================================
- Coverage   87.20%   86.68%   -0.52%     
==========================================
  Files          56       56              
  Lines       17363    17363              
==========================================
- Hits        15141    15051      -90     
- Misses       2222     2312      +90     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nibanks nibanks merged commit 9610803 into microsoft:main Jan 3, 2025
485 of 486 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Build Language: Rust Related to the Rust interop layer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants