Optimize QuicStreamSetUpdateMaxStreams #4852
Merged
+257
−99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4852 +/- ##
==========================================
+ Coverage 85.93% 86.55% +0.62%
==========================================
Files 56 56
Lines 17630 17685 +55
==========================================
+ Hits 15150 15308 +158
+ Misses 2480 2377 -103 ☔ View full report in Codecov by Sentry. |
guhetier
force-pushed
the
guhetier/waiting_stream_list
branch
from
bb0fac7 to
248543d
Compare
nibanks
reviewed
Feb 27, 2025
nibanks
reviewed
Mar 3, 2025
nibanks
added
Area: Performance
Area: Core
nibanks
approved these changes
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Store new streams that are blocked by Stream Id flow control in a sorted list (instead of the hash table containing all streams) to improve the performances of
QuicStreamSetUpdateMaxStreams.It will now be enough to iterate over a subset of this list instead of iterating over the entirety of opened streams when receiving a "MAX_STREAMS" frame increasing the limit.
Closes #3538
Testing
Already covered by existing tests.
Documentation
In code documentation added.