Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds info container as forward context #69

Merged
merged 31 commits into from
Jul 26, 2024
Merged

Adds info container as forward context #69

merged 31 commits into from
Jul 26, 2024

Conversation

sordonia
Copy link
Member

@sordonia sordonia commented Jul 24, 2024 •
edited
Loading

  • adds info container as forward context in ExpertModel
  • changes expert containers to using getitem and setitem to get / set experts
  • some refactoring about Mixin inheritance
  • handles bug with expert merging in container

pclucas14
pclucas14 approved these changes Jul 25, 2024
View reviewed changes
Copy link
Contributor

@pclucas14 pclucas14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Big PR. I am happy if the tests are happy. Nice work :)

mttl/models/containers/expert_containers.py Show resolved Hide resolved
@sordonia sordonia merged commit caad815 into main Jul 26, 2024
6 checks passed
@sordonia sordonia deleted the info-container branch July 26, 2024 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matheper matheper matheper approved these changes

@pclucas14 pclucas14 pclucas14 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sordonia @matheper @pclucas14