SetupDataPkg: Remove bare excepts #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
language:python
Codecov Report
@@ Coverage Diff @@
## main #220 +/- ##
=======================================
Coverage 27.74% 27.74%
=======================================
Files 16 16
Lines 4494 4494
=======================================
Hits 1247 1247
Misses 3247 3247
Flags with carried forward coverage won't be shown. Click here to find out more.
|
kuqin12
approved these changes
Jul 10, 2023
Catching a bare exception is considered bad practice. Catching bare exceptions can make it impossible to interrupt the program (e.g., with Ctrl-C) and can disguise other problems. This removes all bare excepts and instead catches `Exception` which is the base class for all code-generated exceptions.
Javagedes
force-pushed
the
remove-bare-excepts
branch
from
7cbb301
to
8991758
Compare
makubacki
approved these changes
Jul 10, 2023
apop5
approved these changes
Jul 10, 2023
ProjectMuBot
referenced
this pull request
in microsoft/mu_tiano_platforms
Jul 28, 2023
Introduces 4 new commits in [Features/CONFIG](https://github.com/microsoft/mu_feature_config.git). <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/microsoft/mu_feature_config/commit/596e48d875ebb4af2c9416f5120be6297442a231">596e48</a> Move ConfigKnobShimMmLib to MM_STANDALONE module type (<a href="https://github.com/microsoft/mu_feature_config/pull/219">#219</a>)</li> <li><a href="https://github.com/microsoft/mu_feature_config/commit/d3497f6eb80c885c7b8bbb2350803e72afc16653">d3497f</a> Fixing document to reflect the current state (<a href="https://github.com/microsoft/mu_feature_config/pull/213">#213</a>)</li> <li><a href="https://github.com/microsoft/mu_feature_config/commit/f8da32118cc1c0f8a503893d461878a11915beb7">f8da32</a> SetupDataPkg: Remove bare excepts (<a href="https://github.com/microsoft/mu_feature_config/pull/220">#220</a>)</li> <li><a href="https://github.com/microsoft/mu_feature_config/commit/16f231fa5f3196f4912b6ab3deadc95fa2d97ee6">16f231</a> pip: bump edk2-pytool-extensions from 0.23.8 to 0.23.9 (<a href="https://github.com/microsoft/mu_feature_config/pull/221">#221</a>)</li> </ul> </details> Signed-off-by: Project Mu Bot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Catching a bare exception is considered bad practice. Catching bare exceptions can make it impossible to interrupt the program (e.g., with Ctrl-C) and can disguise other problems. This removes all bare excepts and instead catches
Exceptionwhich is the base class for all code-generated exceptions.flow, or firmware?
validation improvement, ...
in build or boot behavior?
a function in a new library class in a pre-existing module, ...
outside direct code modifications (and comments)?
on an a separate Web page, ...
How This Was Tested
N/A
Integration Instructions
N/A