Use correct Openssl inf for SBSA

[kenlautner]

Description

Changed the openssl inf version used to be the full version to match expected functionality. Additionally disabled NETWORK_ISCSI_ENABLE as we weren't using it.

Extra crypto functionality include:

1. Every SHA hash function. The default openssl version support SHA256 only.
2. X509 full functionality (this is connected with item 3)
3. ECC for TLS and other crypto features (item Enable markdownlint plugin #2)

• Impacts functionality?
  • Functionality - Does the change ultimately impact how firmware functions?
  • Examples: Add a new library, publish a new PPI, update an algorithm, ...
• Impacts security?
  • Security - Does the change have a direct security impact on an application,
    flow, or firmware?
  • Examples: Crypto algorithm change, buffer overflow fix, parameter
    validation improvement, ...
• Breaking change?
  • Breaking change - Will anyone consuming this change experience a break
    in build or boot behavior?
  • Examples: Add a new library class, move a module to a different repo, call
    a function in a new library class in a pre-existing module, ...
• Includes tests?
  • Tests - Does the change include any explicit test code?
  • Examples: Unit tests, integration tests, robot tests, ...
• Includes documentation?
  • Documentation - Does the change contain explicit documentation additions
    outside direct code modifications (and comments)?
  • Examples: Update readme file, add feature readme file, link to documentation
    on an a separate Web page, ...

How This Was Tested

Passed BaseCryptLib Unit Tests.

Integration Instructions

N/A

[makubacki]

@kenlautner, I know this might be obvious, but can you list the additional functionality brought in by the change to the PR description?

[TaylorBeebe]

Is this change also supposed to resolve the BaseCryptLibUnitTest failure?

[kenlautner]

Is this change also supposed to resolve the BaseCryptLibUnitTest failure?

Yes it is. I see that it's still failing for Md5 Hashing which was removed from support. We should probably discuss if we want to allow the use of Md5 hashing again or update the test. It's legacy so we should probably add support in special cases such as this.

[kuqin12]

Is this change also supposed to resolve the BaseCryptLibUnitTest failure?

Yes it is. I see that it's still failing for Md5 Hashing which was removed from support. We should probably discuss if we want to allow the use of Md5 hashing again or update the test. It's legacy so we should probably add support in special cases such as this.

So Q35 is not failing this test? Is it because Q35 disabled the deprecated test, or because it is also failing but still in grace period?

[kenlautner]

Is this change also supposed to resolve the BaseCryptLibUnitTest failure?

Yes it is. I see that it's still failing for Md5 Hashing which was removed from support. We should probably discuss if we want to allow the use of Md5 hashing again or update the test. It's legacy so we should probably add support in special cases such as this.

So Q35 is not failing this test? Is it because Q35 disabled the deprecated test, or because it is also failing but still in grace period?

Q35 doesn't use MD5 and it is disabled by default in MU. SBSA enables it by including NetworkBuildOptions.dsc.inc and setting NETWORK_ISCSI_ENABLE to TRUE.