Restore Device Security [Rebase & FF] #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reverts the following commit: "SecurityPkg: Temporarily remove DeviceSecurity (and libspdm) from build" (11506d5) The libspdm submodule is updated in the following commit to use a cmocka from a more reliable host (GitLab). This revert is necessary for that cherry-pick from edk2 to apply. Signed-off-by: Michael Kubacki <[email protected]>
…cka repo As noted in DMTF/libspdm#2707, the cmocka submodule on cryptomilk is unreliable and impacting downstream consumer builds of SecurityPkg. This is considered a regression in that pre-existing workflows that clone and recursively initialize the repo are now broken. The cmocka host was switched to a more reliable gitlab host in DMTF/libspdm#2710. This change updates the submodule in edk2 to use that commit so edk2 users are not blocked by cryptomilk.org service issues. Signed-off-by: Michael Kubacki <[email protected]>
github-actions
bot
added
the
impact:non-functional
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/202311 #276 +/- ##
=================================================
- Coverage 1.35% 0.71% -0.64%
=================================================
Files 162 162
Lines 38591 38521 -70
Branches 265 265
=================================================
- Hits 521 277 -244
+ Misses 38070 38062 -8
- Partials 0 182 +182
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Javagedes
approved these changes
May 30, 2024
os-d
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #275
CHANGE 1:
SecurityPkg: Restore DeviceSecurity (and libspdm submodule)
Reverts the following commit:
"SecurityPkg: Temporarily remove DeviceSecurity (and libspdm) from build"
(11506d5)
The libspdm submodule is updated in the following commit to use a
cmocka from a more reliable host (GitLab). This revert is necessary
for that cherry-pick from edk2 to apply.
CHANGE 2:
[CHERRY-PICK] SecurityPkg: Update libspdm submodule to use GitLab cmocka repo
As noted in DMTF/libspdm#2707, the cmocka
submodule on cryptomilk is unreliable and impacting downstream
consumer builds of SecurityPkg. This is considered a regression in
that pre-existing workflows that clone and recursively initialize
the repo are now broken.
The cmocka host was switched to a more reliable gitlab host in
DMTF/libspdm#2710. This change updates the
submodule in edk2 to use that commit so edk2 users are not blocked
by cryptomilk.org service issues.
How This Was Tested
Integration Instructions