EmbeddedPkg: Enable build under VS2019 and fix build errors. #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VivianNK
approved these changes
Jul 16, 2024
os-d
approved these changes
Jul 16, 2024
apop5
force-pushed
the
personal/apop5/fixembeddedpkg
branch
from
a293090 to
4c7b3ad
Compare
github-actions
bot
added
the
impact:non-functional
apop5
force-pushed
the
personal/apop5/fixembeddedpkg
branch
from
4c7b3ad to
0b55e4f
Compare
makubacki
reviewed
Jul 23, 2024
apop5
force-pushed
the
personal/apop5/fixembeddedpkg
branch
from
0b55e4f to
0402b56
Compare
apop5
added a commit
to apop5/mu_tiano_plus
that referenced
this pull request
Jan 6, 2025
…ft#282) ## Description Turn off modules in EmbeddedPkg's that cannot be compiled under VS. Fix multiple 64 to 32 bit conversions. 8fa524e 6d66d4a (already included in microsoft#287) - [ ] Impacts functionality? - **Functionality** - Does the change ultimately impact how firmware functions? - Examples: Add a new library, publish a new PPI, update an algorithm, ... - [ ] Impacts security? - **Security** - Does the change have a direct security impact on an application, flow, or firmware? - Examples: Crypto algorithm change, buffer overflow fix, parameter validation improvement, ... - [ ] Breaking change? - **Breaking change** - Will anyone consuming this change experience a break in build or boot behavior? - Examples: Add a new library class, move a module to a different repo, call a function in a new library class in a pre-existing module, ... - [ ] Includes tests? - **Tests** - Does the change include any explicit test code? - Examples: Unit tests, integration tests, robot tests, ... - [ ] Includes documentation? - **Documentation** - Does the change contain explicit documentation additions outside direct code modifications (and comments)? - Examples: Update readme file, add feature readme file, link to documentation on an a separate Web page, ... ## How This Was Tested Local CI. ## Integration Instructions N/A Co-authored-by: Bret Barkelew <[email protected]>
apop5
added a commit
that referenced
this pull request
Feb 4, 2025
## Description Turn off modules in EmbeddedPkg's that cannot be compiled under VS. Fix multiple 64 to 32 bit conversions. 8fa524e 6d66d4a (already included in #287) - [ ] Impacts functionality? - **Functionality** - Does the change ultimately impact how firmware functions? - Examples: Add a new library, publish a new PPI, update an algorithm, ... - [ ] Impacts security? - **Security** - Does the change have a direct security impact on an application, flow, or firmware? - Examples: Crypto algorithm change, buffer overflow fix, parameter validation improvement, ... - [ ] Breaking change? - **Breaking change** - Will anyone consuming this change experience a break in build or boot behavior? - Examples: Add a new library class, move a module to a different repo, call a function in a new library class in a pre-existing module, ... - [ ] Includes tests? - **Tests** - Does the change include any explicit test code? - Examples: Unit tests, integration tests, robot tests, ... - [ ] Includes documentation? - **Documentation** - Does the change contain explicit documentation additions outside direct code modifications (and comments)? - Examples: Update readme file, add feature readme file, link to documentation on an a separate Web page, ... ## How This Was Tested Local CI. ## Integration Instructions N/A Co-authored-by: Bret Barkelew <[email protected]>
apop5
added a commit
that referenced
this pull request
Feb 11, 2025
## Description Turn off modules in EmbeddedPkg's that cannot be compiled under VS. Fix multiple 64 to 32 bit conversions. 8fa524e 6d66d4a (already included in #287) - [ ] Impacts functionality? - **Functionality** - Does the change ultimately impact how firmware functions? - Examples: Add a new library, publish a new PPI, update an algorithm, ... - [ ] Impacts security? - **Security** - Does the change have a direct security impact on an application, flow, or firmware? - Examples: Crypto algorithm change, buffer overflow fix, parameter validation improvement, ... - [ ] Breaking change? - **Breaking change** - Will anyone consuming this change experience a break in build or boot behavior? - Examples: Add a new library class, move a module to a different repo, call a function in a new library class in a pre-existing module, ... - [ ] Includes tests? - **Tests** - Does the change include any explicit test code? - Examples: Unit tests, integration tests, robot tests, ... - [ ] Includes documentation? - **Documentation** - Does the change contain explicit documentation additions outside direct code modifications (and comments)? - Examples: Update readme file, add feature readme file, link to documentation on an a separate Web page, ... ## How This Was Tested Local CI. ## Integration Instructions N/A Co-authored-by: Bret Barkelew <[email protected]>
apop5
added a commit
that referenced
this pull request
Feb 14, 2025
## Description Turn off modules in EmbeddedPkg's that cannot be compiled under VS. Fix multiple 64 to 32 bit conversions. 8fa524e 6d66d4a (already included in #287) - [ ] Impacts functionality? - **Functionality** - Does the change ultimately impact how firmware functions? - Examples: Add a new library, publish a new PPI, update an algorithm, ... - [ ] Impacts security? - **Security** - Does the change have a direct security impact on an application, flow, or firmware? - Examples: Crypto algorithm change, buffer overflow fix, parameter validation improvement, ... - [ ] Breaking change? - **Breaking change** - Will anyone consuming this change experience a break in build or boot behavior? - Examples: Add a new library class, move a module to a different repo, call a function in a new library class in a pre-existing module, ... - [ ] Includes tests? - **Tests** - Does the change include any explicit test code? - Examples: Unit tests, integration tests, robot tests, ... - [ ] Includes documentation? - **Documentation** - Does the change contain explicit documentation additions outside direct code modifications (and comments)? - Examples: Update readme file, add feature readme file, link to documentation on an a separate Web page, ... ## How This Was Tested Local CI. ## Integration Instructions N/A Co-authored-by: Bret Barkelew <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Turn off modules in EmbeddedPkg's that cannot be compiled under VS.
Fix multiple 64 to 32 bit conversions.
8fa524e
6d66d4a (already included in #287)
flow, or firmware?
validation improvement, ...
in build or boot behavior?
a function in a new library class in a pre-existing module, ...
outside direct code modifications (and comments)?
on an a separate Web page, ...
How This Was Tested
Local CI.
Integration Instructions
N/A