Correct return types in HTTP methods

microsoft · Nov 14, 2024 · 8018929 · 8018929
1 parent 86fcb9f
commit 8018929
Showing 1 changed file with 8 additions and 8 deletions.
diff --git a/local/o365/classes/httpclient.php b/local/o365/classes/httpclient.php
@@ -95,9 +95,9 @@ protected function get_moodle_version(): string {
      * @param string $url
      * @param array|string $params
      * @param array $options
-     * @return bool
+     * @return mixed
      */
-    public function patch($url, $params = '', $options = []): bool {
+    public function patch($url, $params = '', $options = []): mixed {
         $options['CURLOPT_CUSTOMREQUEST'] = 'PATCH';
 
         if (is_array($params)) {
@@ -125,9 +125,9 @@ public function patch($url, $params = '', $options = []): bool {
      * @param string $url
      * @param array|string $params
      * @param array $options
-     * @return bool
+     * @return mixed
      */
-    public function merge($url, $params = '', $options = []): bool {
+    public function merge($url, $params = '', $options = []): mixed {
         $options['CURLOPT_CUSTOMREQUEST'] = 'MERGE';
 
         if (is_array($params)) {
@@ -155,9 +155,9 @@ public function merge($url, $params = '', $options = []): bool {
      * @param string $url
      * @param array $params
      * @param array $options
-     * @return bool
+     * @return mixed
      */
-    public function put($url, $params = [], $options = []): bool {
+    public function put($url, $params = [], $options = []): mixed {
         if (!isset($params['file'])) {
             throw new moodle_exception('errorhttpclientnofileinput', 'local_o365');
         }
@@ -188,9 +188,9 @@ public function put($url, $params = [], $options = []): bool {
      *
      * @param string $url
      * @param array $options
-     * @return bool
+     * @return mixed
      */
-    public function download_file($url, $options = []): bool {
+    public function download_file($url, $options = []): mixed {
         $url = str_replace(['+', ' '], '%20', $url);
 
         return $this->request($url, $options);