This repository has been archived by the owner on Nov 16, 2023. It is now read-only.
wasm: update backend to consume latest ONNX Runtime #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zuwei-Zhao
reviewed
Apr 23, 2021
tools/build.ts
Outdated
| '--llvm-lto 3', | ||
| ]; | ||
| const OUT_WASM_JS = path.join(OUT, 'onnxruntime_wasm.js'); | ||
| const OUT_WASM = path.join(OUT, 'onnxruntime_wasm.wasm'); |
There was a problem hiding this comment.
Hi, for multi-threading WebAssembly, we will need to change the file names here. Thanks.
Zuwei-Zhao
reviewed
Apr 23, 2021
tools/build.ts
Outdated
| if (exportedFunctions.length === 0) { | ||
| npmlog.error('Build.Wasm', `No exported functions specified in the file: ${SRC_WASM_BUILD_CONFIG}`); | ||
| if (!fs.existsSync(OUT_WASM)) { | ||
| npmlog.error('Build.Wasm', 'Please make sure onnxruntime_wasm.wasm is built and exists in /dist/'); |
There was a problem hiding this comment.
Hi, OUT_WASM needs to be changed to "onnxruntime_wasm_threads.wasm" for multi-threading WebAssembly. Please also consider this in the PR. Thanks.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this change allows to use whole ONNXRuntime as the webassembly backend.