Base commit for using EMSDK 3.1.74 (LTO disabled) #23318
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fs-eire
commented
Jan 10, 2025
Comment on lines
41
to
33
| #string(APPEND CMAKE_C_FLAGS " -flto=thin") | ||
| #string(APPEND CMAKE_CXX_FLAGS " -flto=thin") |
There was a problem hiding this comment.
LTO is disabled temporarily. Should enable it once a fix is available for wasm-ld.
fs-eire
force-pushed
the
fs-eire/emsdk-3.1.74
branch
from
a85fe10 to
81ee27f
Compare
fs-eire
added a commit
that referenced
this pull request
Jan 14, 2025
### Description This PR contains a part of the changes in #23318. The reason of creating this PR is: The works to support building WebGPU EP in WASM depends on #23318, which cannot be merged since it's blocked by upstream (llvm/llvm-project#122166). This PR contains the changes can be safely merged separately and can unblock the development of supporting building WebGPU EP in WASM. --------- Co-authored-by: Copilot <[email protected]>
fs-eire
force-pushed
the
fs-eire/emsdk-3.1.74
branch
from
81ee27f to
af1e75f
Compare
fs-eire
force-pushed
the
fs-eire/emsdk-3.1.74
branch
from
af1e75f to
aad3c79
Compare
|
close in favor of #23415 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgrade EMSDK to
3.1.74.This PR is currently marked as "draft", as LTO is disabled temporarily because of a crash in wasm-ld. Related issue is being tracked in upstream at llvm/llvm-project#122166.
Once a workaround is available, LTO should be re-enabled.