Seperate RN andriod and IOS into 2 separated Stages. #23400
Conversation
config.build_settings['EXCLUDED_ARCHS[sdk=iphonesimulator*]'] = "arm64"
# Conflicts: # js/react_native/e2e/ios/Podfile # js/react_native/ios/OnnxruntimeModule.xcodeproj/project.pbxproj # js/react_native/ios/Podfile
# Conflicts: # js/react_native/e2e/ios/Podfile # js/react_native/e2e/yarn.lock # js/react_native/ios/Podfile # tools/ci_build/github/azure-pipelines/templates/react-native-ci.yml
| jobs: | ||
| - job: ReactNative_CI | ||
| - job: ReactNative_CI_Android |
There was a problem hiding this comment.
Could you use Linux machines to build Android?
There was a problem hiding this comment.
They are more stable, and we have more capacities there.
There was a problem hiding this comment.
If you do it in a new PR if you'd like.
There was a problem hiding this comment.
@edgchen1 That is a question for Edward.
There was a problem hiding this comment.
worth trying it. IIRC, we used to only be able to run the android emulator on Mac agents.
| targetPath: '$(Build.SourcesDirectory)/js/react_native/e2e/artifacts' | ||
| condition: succeededOrFailed() | ||
| displayName: Publish React Native Detox E2E test logs | ||
|
|
||
| - task: PublishPipelineArtifact@0 | ||
| inputs: | ||
| artifactName: '${{parameters.PackageName}}' | ||
| artifactName: 'NPM_packages_android' |
There was a problem hiding this comment.
I think the npm packaging pipeline sets the PackageName parameter.
does it still work with these changes?
There was a problem hiding this comment.
I think the npm packaging pipeline sets the PackageName parameter.
does it still work with these changes?
Good point, but the package 'onnxruntime-react-native' wasn't downloaded later. The default package name, NPM_packages, from RN_CI was used to get downloading artifacts.
There was a problem hiding this comment.
Both NPM_packages_android and NPM_packages_ios contians the same *.tgz. So, we just need to build one of it.
There was a problem hiding this comment.
ok. please verify that other pipelines which use the react-native-ci.yml template still work as expected.
There was a problem hiding this comment.
NPM packaging pipeline uses template react-native-ci.yml.
The expected published artifacts of NPM packaging pipeline is:
- artifact
onnxruntime-web: should include the NPM package ofonnxruntime-web, and should also include the NPM packageonnxruntime-commonif necessary - artifact
onnxruntime-node: should include the NPM package ofonnxruntime-node, and should also include the NPM packageonnxruntime-commonif necessary - artifact
onnxruntime-react-native: should include the NPM package ofonnxruntime-react-native, and should also include the NPM packageonnxruntime-commonif necessary
Since the ONNX Runtime React Native CI Pipeline is a CI pipeline, there is no requirement to its artifact. However, an artifact named as NPM_Packages is expected to have one or more NPM packages. There is no such "Android"/"iOS" version of the package; so NPM_packages_android/NPM_packages_ios is confusing
tools/ci_build/github/azure-pipelines/npm-packaging-pipeline.yml
Outdated
Show resolved
Hide resolved
|
Need to verify the NPM_packages with main branch from Nuget pkg pipeline which is currently broken. |
|
"NPM_Packages" is a general name. It does not indicate the artifact contians a specific package. In a React Native pipeline, it may contain the NPM package The NPM packaging pipeline currently does the following:
|
Description
Seperate RN andriod and IOS into 2 separated Stages.
Motivation and Context
Speed up the PR process.