Fix graph building to exclude input, output and initializer from value_info #1320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e_info [ghstack-poisoned]
BowenBao
added a commit
that referenced
this pull request
Mar 29, 2024
…e_info ghstack-source-id: b9a1745b6d36beba070db773a4d2932288880267 Pull Request resolved: #1320
BowenBao
commented
Mar 29, 2024
| @@ -140,7 +139,6 @@ def test_add_initializer_allows_adding_the_same_tensor_twice_using_same_name(sel | |||
|
|
|||
|
|
|||
| class TestModelSaving(unittest.TestCase): | |||
| @unittest.skipIf(os.getenv("CI") == "true", "CI is not ready to run dyanmo_export.") | |||
There was a problem hiding this comment.
Not sure about the context here.
There was a problem hiding this comment.
Initially we disabled it to avoid flakiness due to the changing pytorch
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Test Results 18 files ± 0 18 suites ±0 1h 7m 43s ⏱️ + 13m 49s For more details on these failures, see this check. Results for commit 17b53c1. ± Comparison against base commit 2612107. ♻️ This comment has been updated with latest results. |
justinchuby
reviewed
Mar 29, 2024
justinchuby
reviewed
Mar 29, 2024
justinchuby
approved these changes
Mar 29, 2024
justinchuby
reviewed
Mar 29, 2024
…r from value_info" Otherwise the emitted model proto instance violates the spec definition for value_info. [ghstack-poisoned]
BowenBao
added a commit
that referenced
this pull request
Mar 29, 2024
…e_info ghstack-source-id: 4c40be31d6af9e243296bfa3dca08ae4a4a5b3b5 Pull Request resolved: #1320
|
Good to merge. #539 |
|
Ouch, wrong base again. |
justinchuby
pushed a commit
that referenced
this pull request
Apr 1, 2024
…e_info (#1321) Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * __->__ #1321 Otherwise the emitted model proto instance violates the spec definition for value_info. Reland #1320
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Otherwise the emitted model proto instance violates the spec definition for value_info.