Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable optimization via environment variable #1869

Merged
merged 1 commit into from
Sep 17, 2024
Merged

Conversation

gramalingam
Copy link
Collaborator

Enable optimization via environment variable

Copy link

codecov bot commented Sep 17, 2024

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
14676 1 14675 1973
View the top 1 failed tests by shortest run time
onnxscript.backend.onnx_export_test.TestOnnxBackEnd test_export2python_produces_correct_onnx_script_model_0612_test_maxpool_2d_precomputed_pads
Stack Traces | 0.005s run time
onnxscript\backend\onnx_export_test.py:137: in extract_functions
    mod = importlib.import_module(import_name)
C:\hostedtoolcache\windows\Python\3.10.11\x64\lib\importlib\__init__.py:126: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
E   ModuleNotFoundError: No module named 'tests.onnx_backend_test_code.test_maxpool_2d_precomputed_pads'

The above exception was the direct cause of the following exception:
.nox\test\lib\site-packages\parameterized\parameterized.py:620: in standalone_func
    return func(*(a + p.args), **p.kwargs, **kw)
onnxscript\backend\onnx_export_test.py:271: in test_export2python_produces_correct_onnx_script_model
    functions = extract_functions(backend_test.name, code, self.test_folder)
onnxscript\backend\onnx_export_test.py:139: in extract_functions
    raise AssertionError(
E   AssertionError: Unable to import 'tests.onnx_backend_test_code.test_maxpool_2d_precomputed_pads' (e=No module named 'tests.onnx_backend_test_code.test_maxpool_2d_precomputed_pads') (file: 'D:\\a\\onnxscript\\onnxscript\\tests\\onnx_backend_test_code\\test_maxpool_2d_precomputed_pads.py', absolute path: 'D:\\a\\onnxscript\\onnxscript\\tests\\onnx_backend_test_code\\test_maxpool_2d_precomputed_pads.py', current folder: D:\a\onnxscript\onnxscript
E   ---- CONTENT --
E   import numpy
E   from onnx import TensorProto
E   from onnx.helper import make_tensor
E   from onnxscript import script, external_tensor
E   from onnxscript.values import Opset
E   from onnxscript.onnx_types import FLOAT
E   from onnxscript.onnx_opset import opset12
E   
E   @script()
E   def bck_test_maxpool_2d_precomputed_pads(x: FLOAT[1,1,5,5]) -> (FLOAT[1,1,5,5]):
E       y = opset12.MaxPool(x, kernel_shape=[5, 5], pads=[2, 2, 2, 2])
E       return y

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

@justinchuby justinchuby enabled auto-merge (squash) September 17, 2024 00:40
@justinchuby justinchuby merged commit a93c04a into main Sep 17, 2024
30 of 41 checks passed
@justinchuby justinchuby deleted the rama/expose-optimizer branch September 17, 2024 00:42
@@ -28,6 +28,9 @@
os.getenv("TORCH_ONNX_OFFLOAD_EXTERNAL_DATA_WITH_IR") != "0"
)

# Internal flag. Will go away.
_TORCH_ONNX_ENABLE_OPTIMIZATION = os.getenv("TORCH_ONNX_ENABLE_OPTIMIZATION") == "1'"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: "1'" -> "1"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants