-
Notifications
You must be signed in to change notification settings - Fork 87
Create initializers with the constant folding pass #2598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Justin Chu <[email protected]>
Signed-off-by: Justin Chu <[email protected]>
Signed-off-by: Justin Chu <[email protected]>
❌ 31 Tests Failed:
View the top 3 failed test(s) by shortest run time
View the full list of 6 ❄️ flaky test(s)
To view more test analytics, go to the Test Analytics Dashboard |
| output_size_limit: int, | ||
| shape_inference: bool = True, | ||
| input_size_limit: int = DEFAULT_CONSTANT_FOLD_INPUT_SIZE_LIMIT, | ||
| output_size_limit: int = DEFAULT_CONSTANT_FOLD_OUTPUT_SIZE_LIMIT, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder why you need two limits. Maybe we could set up the second one to None and replace None and the first value if it is still None.
|
Replaced by #2650 |
Partially From #2598 This provides a better optimized graph after constant folding in terms of the number of nodes, which is better for debugging.
Also Create default values for the constant folding pass