Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
package com.microsoft.playwright.impl;

import com.google.gson.JsonObject;
import com.microsoft.playwright.PlaywrightException;

import java.util.*;
import java.util.function.Consumer;
Expand Down Expand Up @@ -46,6 +47,9 @@ <T> void notify(EventType eventType, T param) {
}

void add(EventType type, Consumer<?> listener) {
if (listener == null) {
throw new PlaywrightException("Can't add a null listener");
}
List<Consumer<?>> list = listeners.get(type);
if (list == null) {
list = new ArrayList<>();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -347,4 +347,13 @@ void shouldPropagateCloseReasonToPendingActions() {
}));
assertTrue(e.getMessage().contains("The reason."), e.getMessage());
}

@Test
void shouldProhibitNullListeners() {
Page newPage = context.newPage();

PlaywrightException e = assertThrows(PlaywrightException.class, () -> newPage.onClose(null));

assertTrue(e.getMessage().contains("Can't add a null listener"));
}
}
Loading