Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: null check in ListenerCollection notify method #1661

Merged
merged 5 commits into from
Aug 28, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
package com.microsoft.playwright.impl;

import com.google.gson.JsonObject;
import com.microsoft.playwright.PlaywrightException;

import java.util.*;
import java.util.function.Consumer;
Expand Down Expand Up @@ -46,6 +47,9 @@ <T> void notify(EventType eventType, T param) {
}

void add(EventType type, Consumer<?> listener) {
if (listener == null) {
throw new PlaywrightException("Can't add a null listener");
}
List<Consumer<?>> list = listeners.get(type);
if (list == null) {
list = new ArrayList<>();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -347,4 +347,13 @@ void shouldPropagateCloseReasonToPendingActions() {
}));
assertTrue(e.getMessage().contains("The reason."), e.getMessage());
}

@Test
void shouldProhibitNullListeners() {
Page newPage = context.newPage();

PlaywrightException e = assertThrows(PlaywrightException.class, () -> newPage.onClose(null));

assertTrue(e.getMessage().contains("Can't add a null listener"));
}
}
Loading