feat: relax dependencies in pyproject.toml and add a requirements.txt #2669
+14
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@microsoft-github-policy-service agree [company="Preset Inc."] |
|
@mistercrunch the command you issued was incorrect. Please try again. Examples are: and |
mxschmitt
reviewed
Nov 27, 2024
| @@ -0,0 +1,8 @@ | |||
| # This file was autogenerated by uv via the following command: | |||
| # uv pip compile pyproject.toml -o requirements.txt | |||
| greenlet==3.1.1 | |||
There was a problem hiding this comment.
What I'm worried about here is that when e.g. greenlet 3.1.2 comes out, which includes e.g. a breaking change or a bug for some reason, our CI would still run with 3.1.1 and not install the bad version.
Why is the requirements.txt file needed at all in this case? To provide reproducible builds?
mxschmitt
reviewed
Nov 27, 2024
| @@ -13,8 +13,8 @@ license = {text = "Apache-2.0"} | |||
| dynamic = ["version"] | |||
| requires-python = ">=3.9" | |||
| dependencies = [ | |||
| "greenlet==3.1.1", | |||
| "pyee==12.1.1", | |||
| "pyee>=12.1.1", | |||
There was a problem hiding this comment.
Make sure to relax the version in the meta.yaml as well for our conda customers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to this: #2666
uvas it seems it's what the cool kids are using nowadays.github/workflows/and modified so that it would install the pinned filesNOTE:
local-requirements.txtfile and addeduvto it, though I'd recommend moving tooptional-dependenciesin pyproject.toml, maybe as unpinned there, and generate a requirements-dev.txt or similar from there. Though not super important