chore: browserserver #643
chore: browserserver #643
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the ReusedBrowser class to first attempt connecting to an existing browser server before spawning a new one, and wires up the transport close event in BackendClient.
- Introduces
_connectToBrowserServerto probe and attach to a running server on localhost:14518 - Updates startup flow to fallback to launching a new server only if no existing server is found
- Hooks
this._transport.oncloseto fire the internal close event inBackendClient
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/reusedBrowser.ts | Added connection-attempt logic and helper method |
| src/backend.ts | Bound transport.onclose to _onCloseEvent.fire() |
Comments suppressed due to low confidence (1)
src/reusedBrowser.ts:198
- [nitpick] The new helper method lacks JSDoc or comments explaining its behavior and expected return values; adding documentation will improve maintainability.
private async _connectToBrowserServer(): Promise<Backend | null> {
| if (typeof json.wsEndpointPath !== 'string') | ||
| return null; | ||
| const client = new Backend(this._vscode); | ||
| await client._connect(baseURL.toString()); |
There was a problem hiding this comment.
The returned wsEndpointPath from the /json endpoint is never used; instead of connecting to baseURL directly, construct the WebSocket URL with json.wsEndpointPath (e.g. await client._connect(new URL(json.wsEndpointPath, baseURL).toString())).
| await client._connect(baseURL.toString()); | |
| await client._connect(new URL(json.wsEndpointPath, baseURL).toString()); |
Copilot uses AI. Check for mistakes.
| @@ -191,6 +195,24 @@ export class ReusedBrowser implements vscodeTypes.Disposable { | |||
| return {}; | |||
| } | |||
|
|
|||
| private async _connectToBrowserServer(): Promise<Backend | null> { | |||
| try { | |||
| const baseURL = new URL('http://localhost:14518'); | |||
There was a problem hiding this comment.
[nitpick] Hardcoding the browser server URL and port limits flexibility; consider extracting the host/port into a config or environment variable.
| const baseURL = new URL('http://localhost:14518'); | |
| const host = process.env.BROWSER_SERVER_HOST || 'localhost'; | |
| const port = process.env.BROWSER_SERVER_PORT || '14518'; | |
| const baseURL = new URL(`http://${host}:${port}`); |
Copilot uses AI. Check for mistakes.
| await client._connect(baseURL.toString()); | ||
| return client; | ||
| } catch (e) { | ||
| console.error('Failed to connect to browser server:', e); |
There was a problem hiding this comment.
[nitpick] Using console.error directly may not integrate with the project's logging framework; consider using a centralized logger for consistency.
Copilot uses AI. Check for mistakes.
|
revision 2: microsoft/playwright#36382 |
Counterpart of microsoft/playwright#36327.