fix(expect): if actual snapshot happens to not exist, don't crash #36234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test results for "tests 1"1 failed 6 flaky39351 passed, 820 skipped Merge workflow run. |
AntonioVentilii
added a commit
to dfinity/oisy-wallet
that referenced
this pull request
Jun 12, 2025
# Motivation The E2E tests are failing when the screenshot already exists. It is a race-condition issue with playwright (see [issue](microsoft/playwright#36228) and [fix-PR](microsoft/playwright#36234)). So, it may happen that the screenshot is partially saved and the test fails. Since the fix will only be released in v1.54 of playwright (see [comment in issue thread](microsoft/playwright#36228 (comment))), and we need to move forward with the tests, for now we ignore eventual errors given by screenshots, accepting even partial screenshots. At the same time, we left behind a few fixes to make the screenshots work. # Changes - Wrap `toHaveScreenshot` into a try-catch statement that ignores any error. - Fix test id for token groups. - Revert II playwright to latest non-breaking-changes version (we will tackle the breaking-changes with a bump in another PR). - Skip `rewards` page tests: we have a new `earn` page in staging that requires its own E2E tests. # Tests Screenshots are being saved too. --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the crashing component of #36228.
page._expectScreenshot()has complicated logic to determine its return value and the returned type is not as typesafe as it should be. Under certain race conditions it is possible to timeout while still successfully taking a screenshot (similar to #36181).Address the symptom and prevent Playwright from crashing when
actualis nullish.