Skip to content

feat: Make request tab sections collapsible with visual hierarchy #36313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

Nihal-Kumar
Copy link

@Nihal-Kumar Nihal-Kumar commented Jun 15, 2025

  • Adds collapsible sections for request tab headers like General, Request Headers, Query Parameters, etc.
  • Introduces showing header count when header collapsed.
  • Improves visual hierarchy of key-value pairs by styling keys with font weight and making the UI closer to Browser Dev Tools
  • No new dependencies added.

Updates:
https://github.com/user-attachments/assets/67c63608-bd3e-48c8-9f68-19edd7445cfc

Images:
image
image

Before:
image

References: #35214

@Nihal-Kumar
Copy link
Author

@microsoft-github-policy-service agree

This comment has been minimized.

This comment has been minimized.

@dgozman
Copy link
Contributor

dgozman commented Jun 15, 2025

@Nihal-Kumar Before we consider this PR, please file an issue first that describes the improvements, and also include a screenshot/screencast. Thank you!

@Nihal-Kumar
Copy link
Author

Sure @dgozman
This PR references an existing issue, I have updated the initial comment with all the details. I will update the failing tests and push the changes.
Please let me know if anything else is required. Thanks!

<div
className='network-collapsible-header'
onClick={() => setIsOpen(!isOpen)}
style={{ display: 'flex', alignItems: 'center', cursor: 'pointer' }}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could these inline styles please be added to the stylesheet instead of in-line styles

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@Nihal-Kumar Nihal-Kumar requested a review from yasboyman June 18, 2025 20:48
Copy link
Contributor

Test results for "tests 1"

4 flaky ⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-ubuntu-22.04-node18
⚠️ [webkit-library] › library/browsercontext-viewport-mobile.spec.ts:157:5 › mobile viewport › mouse should work with mobile viewports and cross process navigations @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › page/page-screenshot.spec.ts:345:5 › page screenshot › should work while navigating @webkit-ubuntu-22.04-node18
⚠️ [playwright-test] › ui-mode-test-watch.spec.ts:145:5 › should watch all @windows-latest-node18-1

39423 passed, 822 skipped
✔️✔️✔️

Merge workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants