chore: make various progress instances "strict" #36349
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
dgozman
force-pushed
the
chore-progress-misc-strict
branch
from
05f87c2 to
adc561f
Compare
This comment has been minimized.
This comment has been minimized.
yury-s
approved these changes
Jun 19, 2025
| await this.clearPermissions(); | ||
| await this.setExtraHTTPHeaders(this._options.extraHTTPHeaders || []); | ||
| await this.setGeolocation(this._options.geolocation); | ||
| await this.setOffline(!!this._options.offline); |
There was a problem hiding this comment.
shouldn't all these protocol calls take progress (eventually) ?
There was a problem hiding this comment.
I am not yet sure. There are some calls that need specific cleanup and so cannot just be generalized as "race this protocol call with a progress".
dgozman
force-pushed
the
chore-progress-misc-strict
branch
from
adc561f to
48fb62b
Compare
Test results for "tests 1"1 failed 5 flaky39444 passed, 823 skipped Merge workflow run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.