feat(toMatchAriaSnapshot): add exact saving option #38075
+243
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes microsoft#38074, references microsoft#38074.
agg23
requested changes
Oct 31, 2025
There was a problem hiding this comment.
Thank you for your contribution. We always ask that people file issues first so we can triage and decide whether or not a PR is warranted, but in this case we do think this is something worth implementing (and it's a trivial implementation).
Minor comments: just naming and supporting both overloads.
Test results for "MCP"2588 passed, 116 skipped Merge workflow run. |
Test results for "tests 1"2 flaky40357 passed, 789 skipped Merge workflow run. |
agg23
requested changes
Nov 3, 2025
docs/src/api/params.md
Outdated
| * since: v1.57.0 | ||
| - `update` <["raw"]|["relaxed"]> | ||
|
|
||
| Controls how the snapshot is updated. |
There was a problem hiding this comment.
Follow the style of similar options like updateSnapshots
I think something like this (feel free to give your opinion on the language):
Defines how the snapshot is updated when used with [`method: TestConfig.updateSnapshots`]. Defaults to `'relaxed'`.
* `'relaxed'` - Saves the accessibility snapshot with a relaxed matching structure (for example regular expressions to match number combinations).
* `'raw'` - Saves the unmodified accessibility snapshot. This snapshot is an exact match and will not match content with changed values.There was a problem hiding this comment.
updated docs in last commit, very similar to your suggestion
…apshot, update tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add exact parameter to toMatchAriaSnapshot to save raw data
Fixes #38074, references #38074.