fixed 0 minimum bug for not 0 minimum value (#21)

microsoft · Nov 10, 2017 · a44042c · a44042c
1 parent 48bd304
commit a44042c
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 6 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,6 @@
+## 1.5.2
+* Fixed bug when not 0 minimum value calculated as 0
+
 ## 1.5.1
 * Added check for null objects toString call
 

diff --git a/package.json b/package.json
@@ -1,7 +1,7 @@
 {
   "name": "powerbi-visuals-bulletchart",
   "description": "Bullet chart",
-  "version": "1.5.1",
+  "version": "1.5.2",
   "author": {
     "name": "Microsoft",
     "email": "[email protected]"

diff --git a/pbiviz.json b/pbiviz.json
@@ -4,7 +4,7 @@
     "displayName": "Bullet Chart",
     "guid": "BulletChart1443347686880",
     "visualClassName": "BulletChart",
-    "version": "1.5.1",
+    "version": "1.5.2",
     "description": "A bullet chart that includes four orientations and a few customization options. Use to feature a single measure against a qualitative range.",
     "supportUrl": "http://community.powerbi.com",
     "gitHubUrl": "https://github.com/Microsoft/powerbi-visuals-bulletchart"

diff --git a/src/visual.ts b/src/visual.ts
@@ -230,7 +230,7 @@ module powerbi.extensibility.visual {
 
                 let anyRangeIsDefined: boolean = [needsImprovement, satisfactory, good, veryGood].some(_.isNumber);
 
-                minimum = _.isNumber(minimum) && categoricalValues.Minimum ? minimum : BulletChart.zeroValue;
+                minimum = _.isNumber(minimum) ? minimum : BulletChart.zeroValue;
                 needsImprovement = _.isNumber(needsImprovement) ? Math.max(minimum, needsImprovement) : needsImprovement;
                 satisfactory = _.isNumber(satisfactory) ? Math.max(satisfactory, needsImprovement) : satisfactory;
                 good = _.isNumber(good) ? Math.max(good, satisfactory) : good;
@@ -388,11 +388,11 @@ module powerbi.extensibility.visual {
         }
 
         public static getRangeValue(value: number, percent: number, targetValue: number, minimum?: number): number {
-            let negativeMinimumCoef: number;
+            let negativeMinimumCoef: number = 0;
 
             if (minimum === undefined) {
                 negativeMinimumCoef = value ? value : BulletChart.zeroValue;
-            } else {
+            } else if (minimum < 0) {
                 negativeMinimumCoef = minimum;
             }
 

diff --git a/test/visualData.ts b/test/visualData.ts
@@ -47,7 +47,7 @@ module powerbi.extensibility.visual.test {
         public valuesCategory = ["One", "Two", "Three", "Four", "Five", "Six", "Seven", "Eight"];
         public valuesValue = [2, 4, 3, 3, 4, 3, 4, 5];
         public valuesTargetValue = [3, 3, 3, 2, 2, 2, 3, 3];
-        public valuesMinimum = [1, 1, 1, 1, 1, 1, 2, 2];
+        public valuesMinimum = [-1, 1, 1, 1, 1, 1, 2, 2];
         public valuesSatisfactory = [2, 2, 2, 3, 3, 3, 3, 3];
         public valuesGood = [4, 4, 4, 6, 6, 6, 4, 4];
         public valuesMaximum = [6, 6, 6, 8, 8, 8, 8, 7];