Fixed breaking issue if string value used instead of number in Values…

… field bucket (#16)
microsoft · Jan 12, 2018 · aca90fd · aca90fd
1 parent 5425cd5
commit aca90fd
Show file tree

Hide file tree

Showing 5 changed files with 27 additions and 6 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,6 @@
+## 1.4.1
+* Fixed breaking issue if string value used instead of number in Values field bucket
+
 ## 1.4.0
 * Stream Graph: Community suggestions
 * Data Labels option can now displays measure *field name* measure *value*.

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "powerbi-visuals-streamgraph",
-  "version": "1.4.0",
+  "version": "1.4.1",
   "description": "A stacked area chart with smooth interpolation. Often used to display values over time.",
   "repository": {
     "type": "git",

diff --git a/pbiviz.json b/pbiviz.json
@@ -4,7 +4,7 @@
     "displayName": "Stream Graph",
     "guid": "StreamGraph1446659696222",
     "visualClassName": "StreamGraph",
-    "version": "1.4.0",
+    "version": "1.4.1",
     "description": "A stacked area chart with smooth interpolation. Often used to display values over time.",
     "supportUrl": "https://aka.ms/customvisualscommunity",
     "gitHubUrl": "https://github.com/Microsoft/powerbi-visuals-streamgraph"

diff --git a/src/visual.ts b/src/visual.ts
@@ -189,6 +189,10 @@ module powerbi.extensibility.visual {
             };
         }
 
+        public static isNumber(value: PrimitiveValue) {
+            return !isNaN(value as number) && isFinite(value as number) && value !== null;
+        }
+
         public static converter(
             dataView: DataView,
             colorPalette: IColorPalette,
@@ -296,9 +300,9 @@ module powerbi.extensibility.visual {
                     }
                     let streamDataPoint: StreamDataPoint = {
                         x: dataPointValueIndex,
-                        y: isNaN(y)
-                            ? StreamGraph.DefaultValue
-                            : y,
+                        y: StreamGraph.isNumber(y)
+                            ? y
+                            : StreamGraph.DefaultValue,
                         text: label,
                         labelFontSize: fontSizeInPx
                     };
@@ -987,7 +991,7 @@ module powerbi.extensibility.visual {
                 .x((dataPoint: StreamDataPoint) => xScale(dataPoint.x))
                 .y0((dataPoint: StreamDataPoint) => yScale(dataPoint.y0))
                 .y1((dataPoint: StreamDataPoint) => yScale(dataPoint.y0 + dataPoint.y))
-                .defined((dataPoint: StreamDataPoint) => !isNaN(dataPoint.y0) && !isNaN(dataPoint.y));
+                .defined((dataPoint: StreamDataPoint) => StreamGraph.isNumber(dataPoint.y0) && StreamGraph.isNumber(dataPoint.y));
 
             const selection: UpdateSelection<StreamGraphSeries> = this.dataPointsContainer
                 .selectAll(StreamGraph.LayerSelector.selectorName)

diff --git a/test/visualTest.ts b/test/visualTest.ts
@@ -450,6 +450,20 @@ module powerbi.extensibility.visual.test {
                     visualBuilder.visualHost);
             });
 
+            describe("isNumber" , () => {
+                it("should define number values", () => {
+                    const valueNumber = 100,
+                        valueNull = null,
+                        valueUndefined = undefined,
+                        valueNan = NaN;
+
+                    expect(VisualClass.isNumber(valueNumber)).toBeTruthy();
+                    expect(VisualClass.isNumber(valueNull)).toBeFalsy();
+                    expect(VisualClass.isNumber(valueUndefined)).toBeFalsy();
+                    expect(VisualClass.isNumber(valueNan)).toBeFalsy();
+                });
+            });
+
             describe("streamData", () => {
                 let streamData: StreamData;