Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add keyboard navigation and custom styles for focused elements #70

Merged
merged 7 commits into from
Nov 16, 2023
Merged

Add keyboard navigation and custom styles for focused elements #70

merged 7 commits into from
Nov 16, 2023

Conversation

adiletelf
Copy link
Contributor

Also, I tested multiple selection with keyboard using Ctrl, Shift, Meta keys and it works.

Copy link
Contributor

@MulyukovAidar MulyukovAidar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bump visual version in package.json (then npm i for package-lock.json update), also bump version in pbiviz.json

@MulyukovAidar
Copy link
Contributor

Fix focus order. Elements should be focused top to bottom

@MulyukovAidar MulyukovAidar merged commit 6b8d019 into microsoft:dev Nov 16, 2023
3 checks passed
@adiletelf adiletelf deleted the dev branch November 16, 2023 13:46
MulyukovAidar added a commit that referenced this pull request Jan 12, 2024
* Update build.yml (#69)

* New translations

* Add keyboard navigation and custom styles for focused elements (#70)

* Add keyboard navigation and custom styles for focused elements

* Add keyboard navigation tests

* Refactor test and remove unnecessary import

* Reverse the order of the series so that the focus goes from up to down.

* Remove unused dependencies, update Node version to 20.x

* Update .build.yml

* Resolve conflict errors

* Remove outline on non-keyboard focus. Fix stream focus order. (#72)

* Remove outline on non-keyboard focus. Fix focus order

* Remove tslint.json and specify Chromium path for karma tests

* Fix focus order: goes from down to up

* Fix version to use 4 digits

* Update version to 3.0.5.0 (#73)

* New translations (#64)

merging localizations

* Revert "New translations (2023-09-07 13:06:52 UTC)" (#76)

---------

Co-authored-by: pbicvloc <[email protected]>
Co-authored-by: adiletelf <[email protected]>
MulyukovAidar added a commit that referenced this pull request Jun 3, 2024
* New translations

* Add keyboard navigation and custom styles for focused elements (#70)

* Add keyboard navigation and custom styles for focused elements

* Add keyboard navigation tests

* Refactor test and remove unnecessary import

* Reverse the order of the series so that the focus goes from up to down.

* Remove unused dependencies, update Node version to 20.x

* Update .build.yml

* Resolve conflict errors

* Remove outline on non-keyboard focus. Fix stream focus order. (#72)

* Remove outline on non-keyboard focus. Fix focus order

* Remove tslint.json and specify Chromium path for karma tests

* Fix focus order: goes from down to up

* Fix version to use 4 digits

* Update version to 3.0.5.0 (#73)

* New translations (#64)

merging localizations

* Revert "New translations (2023-09-07 13:06:52 UTC)" (#76)

* Add support for ContextMenu when clicking on empty space (#78)

* Add support for ContextMenu when clicking on empty space

When right-clicking on empty space the context menu is shown with actions like copy, share and so on.

* Fix don't show contextmenu twice when clicking on stream

* Replace playwright with playwright-chromium

* Update powerbi-visuals-api to 5.7.0 (#79)

* New translations

* Fix render bugs and enhance readability in high contrast mode (#82)

* Fix "Data Labels" Card, remove redundant slicer "show"

* Make label color visible in high contrast mode when it's the same as background color

* Force high contrast colors in high contrast mode

* Fix colors in high contrast mode for axis and legend (#83)

* Fix colors in high contrast mode for axis and legend

* Increase version to 3.0.8.0

* Fix entry for 3.0.8.0 in CHANGELOG.md

* Bump version to 3.0.9.0 (#84)

* Bump version to 3.0.9.0

* Update packages

* Revert "Update packages"

This reverts commit baed5fc.

---------

Co-authored-by: pbicvloc <[email protected]>
Co-authored-by: adiletelf <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants