Skip to content

Commit

Permalink
Fix the bug with scroll area being too big (#169)
Browse files Browse the repository at this point in the history
* Fix the bug with scroll area being too big

On the scroll event I translate header using "transform" property.
But on the update event, there's an issue when content shrinks,
but the header stays on the same position; it may cause the header
being farther to the right than the content.

This commit translates the header to the correct position and
forces browser to recompute scroll area, so you wouldn't
scroll past content and header.

* Fix the bug with scroll area being too big and update packages

* Fix eslint error
  • Loading branch information
adiletelf authored Sep 26, 2024
1 parent 229e1be commit e968398
Show file tree
Hide file tree
Showing 7 changed files with 325 additions and 143 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 2.5.10
* Fix the bug with scroll area being too big
* Update packages

## 2.5.9
* Fix the bug with header not moving on scrolling horizontally
* Fix npm vulnerabilities
Expand Down
2 changes: 1 addition & 1 deletion karma.conf.ts
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ module.exports = (config) => {
files: [
testRecursivePath,
],
frameworks: ["jasmine"],
frameworks: ["jasmine", "webpack"],
junitReporter: {
outputDir: path.join(__dirname, coverageFolder),
outputFile: "TESTS-report.xml",
Expand Down
Loading

0 comments on commit e968398

Please sign in to comment.