Fix the bug with header not moving when scrolling horizontally #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Demonkratiy
reviewed
Sep 23, 2024
Demonkratiy
reviewed
Sep 23, 2024
src/timeLine.ts
Outdated
| @@ -1393,6 +1399,9 @@ export class Timeline implements powerbiVisualsApi.extensibility.visual.IVisual | |||
|
|
|||
| this.renderTimeRangeText(timelineData, settings.rangeHeader); | |||
|
|
|||
| // reset scroll position | |||
There was a problem hiding this comment.
When we change the granularity the visual triggers update event. Already existing header element has `transform="translate(x, 0)" value, meaning the scroll is not reset by default.
It's apparent no the screenshot below
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you scroll the visual horizontally the expected behavior is for the header to stick in the same position, but it started to move left on the scroll, making it invisible for the user.
Now, with the scroll event the header is moving accordingly and is always visible.