Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove share tech mono #6699

Merged
merged 1 commit into from
Feb 20, 2025
Merged

remove share tech mono #6699

merged 1 commit into from
Feb 20, 2025

Conversation

riknoll
Copy link
Member

@riknoll riknoll commented Feb 20, 2025

replaces share tech mono with the standard microsoft font string. no more annoying monospace font!

look how much better it looks:

image

@riknoll riknoll requested a review from a team February 20, 2025 00:46
Copy link
Contributor

@thsparks thsparks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤩

@@ -12,14 +12,14 @@
Fonts
--------------------*/

@headerFont : "Share Tech Mono", Monaco, Menlo, "Ubuntu Mono", Consolas, source-code-pro, monospace;
@pageFont : "Share Tech Mono", Monaco, Menlo, "Ubuntu Mono", Consolas, source-code-pro, monospace;
@headerFont : 'Segoe UI', 'Segoe UI Web (West European)', -apple-system, BlinkMacSystemFont, Roboto, 'Helvetica Neue', sans-serif;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the kerning/tracking with the colors and this font accessible? I find some of the words in the different colors hard to read.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@srietkerk this is the font msft uses for everything, so i'm sure it meets all of the accessibility standards

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but you are correct that some of our blocks colors do not

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't the accessibility of a font change based on the color and weight you give the font? In particular, I find the weight and the closeness of the letters of the music category to be particularly difficult.
image
versus the spacing it was given before
image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you might be right that it's just the color contrast that makes it harder to read.

@riknoll riknoll merged commit 580ab92 into master Feb 20, 2025
4 checks passed
@riknoll riknoll deleted the dev/riknoll/no-more-monospace branch February 20, 2025 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants