Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Music Changes #1024

Merged
merged 3 commits into from
Jul 18, 2023
Merged

Music Changes #1024

merged 3 commits into from
Jul 18, 2023

Conversation

THEb0nny
Copy link
Contributor

Added group names to ns.ts, corresponding groups are specified for blocks. And some clarifying changes have been made. Something unnecessary has been removed.

Before change
image

After the changes
image

Added group names to ns.ts, corresponding groups are specified for blocks. And some clarifying changes have been made. Something unnecessary has been removed.
@THEb0nny
Copy link
Contributor Author

@jwunderl look here please

Copy link
Member

@jwunderl jwunderl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please undo indentation change in music.cpp, otherwise LGTM~

libs/music/music.cpp Show resolved Hide resolved
@THEb0nny THEb0nny requested a review from jwunderl July 18, 2023 04:47
Copy link
Member

@jwunderl jwunderl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@jwunderl jwunderl merged commit 57b84d9 into microsoft:master Jul 18, 2023
2 checks passed
@THEb0nny THEb0nny deleted the grouping-music-blocks branch July 18, 2023 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants