Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Update testghpkgs workflow to be able to run it again. #5754

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

microbit-carlos
Copy link
Collaborator

It's been a while since this workflow was run, so it needed some minor updates.

Comment on lines -13 to -14
node-version: [8.x]
branch: [stable3.0]
Copy link
Collaborator Author

@microbit-carlos microbit-carlos Jul 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than have the branch in the yaml file, I've added it as a workflow form input, so that it can be set to whatever it's needed at the point the workflow is manually triggered:
image

branch-or-commit:
description: Branch or commit to checkout for test
required: false
default: 'master'
Copy link
Collaborator Author

@microbit-carlos microbit-carlos Jul 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've set the default to the main branch, the workflow has testing on stable3, so if needed we could change this to one of the stable branches.
However, since the form has to be triggered manually, I think it's probably fine to input that at the time it's triggered.

@microbit-carlos
Copy link
Collaborator Author

I'm manually triggered this workflow and it's currently running agains the srietkerk/codal-bump-0.2.67 branch:
https://github.com/microsoft/pxt-microbit/actions/runs/10149336339/job/28064053783

@microbit-carlos microbit-carlos marked this pull request as ready for review July 30, 2024 12:06
@microbit-carlos
Copy link
Collaborator Author

@abchatra this is running correctly, so it's ready to be reviewed.

@abchatra abchatra requested a review from riknoll July 31, 2024 00:47
@abchatra
Copy link
Contributor

@riknoll to review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants