Skip to content

Commit

Permalink
Fix Minecraft HOC Zoom Slider. The blockly fieldSlider styling was be…
Browse files Browse the repository at this point in the history
…ing applied generically to all range inputs, including the zoom slider. To stop this, I've added a class to the fieldSlider input and added that more specific selector to its css.
  • Loading branch information
thsparks committed Oct 17, 2024
1 parent f341d99 commit 1672ddd
Showing 1 changed file with 8 additions and 7 deletions.
15 changes: 8 additions & 7 deletions pxtblocks/plugins/math/fieldSlider.ts
Original file line number Diff line number Diff line change
Expand Up @@ -175,6 +175,7 @@ export class FieldSlider extends Blockly.FieldNumber {

protected createSlider() {
const slider = document.createElement("input");
slider.setAttribute('class', 'blocklyFieldSlider');
slider.type = "range";
slider.min = this.getMin() + "";
slider.max = this.getMax() + "";
Expand Down Expand Up @@ -247,14 +248,14 @@ Blockly.Css.register(`
margin-left: 10px;
}
input[type=range] {
input[type=range].blocklyFieldSlider {
-webkit-appearance: none;
width: 100%;
}
input[type=range]:focus {
input[type=range].blocklyFieldSlider:focus {
outline: none;
}
input[type=range]::-webkit-slider-runnable-track {
input[type=range].blocklyFieldSlider::-webkit-slider-runnable-track {
-webkit-appearance: none;
margin: 8px;
height: 22px;
Expand All @@ -264,7 +265,7 @@ input[type=range]::-webkit-slider-runnable-track {
margin-bottom: 20px;
background: var(--blocklyFieldSliderBackgroundColor);
}
input[type=range]::-webkit-slider-thumb {
input[type=range].blocklyFieldSlider::-webkit-slider-thumb {
-webkit-appearance: none;
width: 26px;
height: 26px;
Expand All @@ -276,7 +277,7 @@ input[type=range]::-webkit-slider-thumb {
box-shadow: 0 0 0 4px rgba(0, 0, 0, 0.15);
cursor: pointer;
}
input[type=range]::-moz-range-track {
input[type=range].blocklyFieldSlider::-moz-range-track {
margin: 8px;
height: 22px;
width: 95%;
Expand All @@ -285,7 +286,7 @@ input[type=range]::-moz-range-track {
margin-bottom: 20px;
background: #547AB2;
}
input[type=range]::-moz-range-thumb {
input[type=range].blocklyFieldSlider::-moz-range-thumb {
width: 26px;
height: 26px;
margin-top: -1px;
Expand All @@ -296,4 +297,4 @@ input[type=range]::-moz-range-thumb {
box-shadow: 0 0 0 4px rgba(0, 0, 0, 0.15);
cursor: pointer;
}
`)
`)

0 comments on commit 1672ddd

Please sign in to comment.