fix up types

microsoft · Sep 19, 2024 · c4fd26c · c4fd26c
1 parent fbd8456
commit c4fd26c
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/localtypings/pxteditor.d.ts b/localtypings/pxteditor.d.ts
@@ -1296,7 +1296,14 @@ declare namespace pxt.editor {
 
     interface BaseAssetEditorResponse {
         id?: number;
+        /**
+         * indicate if operation started or completed successfully
+         */
         success: boolean;
+        /**
+         * Error object if any
+         */
+        error?: any;
     }
 
     interface OpenAssetEditorResponse extends BaseAssetEditorResponse {

diff --git a/pxtservices/iframeDriver.ts b/pxtservices/iframeDriver.ts
@@ -98,9 +98,9 @@ export abstract class IframeDriver {
     }
 
     protected resolvePendingMessage(event: MessageEvent) {
-        const data = event.data as pxt.editor.EditorMessageResponse;
-        if (data.id && this.pendingMessages[data.id]) {
-            const resp = event.data as pxt.editor.EditorMessageResponse;
+        const resp = event.data as pxt.editor.EditorMessageResponse | pxt.editor.AssetEditorResponse;
+
+        if (resp.id && this.pendingMessages[resp.id]) {
             const pending = this.pendingMessages[resp.id!];
             delete this.pendingMessages[resp.id!];