Apply suggestions from code review

Co-authored-by: Eric Anderson <[email protected]>
microsoft · Jan 31, 2024 · d3a95cb · d3a95cb
1 parent 8d0e79c
commit d3a95cb
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/teachertool/src/state/reducer.ts b/teachertool/src/state/reducer.ts
@@ -61,7 +61,7 @@ export default function reducer(state: AppState, action: Action): AppState {
             };
         }
         case "SET_RUBRIC": {
-            updateStoredRubricAsync(state.rubric, action.rubric); // fire and forget, we don't need to wait for this to finish.
+            /*await*/ updateStoredRubricAsync(state.rubric, action.rubric); // fire and forget, we don't need to wait for this to finish.
             return {
                 ...state,
                 rubric: action.rubric,

diff --git a/teachertool/src/transforms/tryLoadLastActiveRubricAsync.ts b/teachertool/src/transforms/tryLoadLastActiveRubricAsync.ts
@@ -46,7 +46,7 @@ export async function tryLoadLastActiveRubricAsync() {
         lastActiveRubric.criteria = lastActiveRubric.criteria.filter(validateCriteriaInstance);
 
         if (lastActiveRubric.criteria.length !== initialCriteriaCount) {
-            postNotification(makeNotification("Some criteria could not be loaded.", 2000));
+            postNotification(makeNotification(lf("Some criteria could not be loaded."), 2000));
         }
 
         dispatch(Actions.setRubric(lastActiveRubric));