fix interleaving of save/sync operations #10166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes microsoft/pxt-microbit#5926
this fixes a bug caused by interleaving save/sync operations when duplicating a project from within the code editor.
we maintain a global array of all the available headers in the current workspace that we pull projects from. currently, that array gets updated in two places:
if a sync operation gets triggered after we start saving a new project but before that save has actually completed, it can accidentally overwrite the change that was made when we saved a new project.
luckily, it's an easy fix. we just need to wait to add the project to the header array until after it's actually saved.