Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support blocks generated from static class methods #10188

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

riknoll
Copy link
Member

@riknoll riknoll commented Sep 16, 2024

Support blocks defined as static methods on classes.

This works fine in the editor, but for some reason when I attempted to add a test case to the decompiler tests I was getting errors. I'll need to do some more investigation to figure out what's different between those two scenarios; this isn't the first time that the decompiler tests have given me grief on things that worked fine. I'm guessing it's an issue with the annotate function.

@riknoll riknoll requested a review from a team September 16, 2024 19:48
Copy link
Contributor

@eanders-ms eanders-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@eanders-ms eanders-ms merged commit fe3898c into master Sep 16, 2024
7 checks passed
@eanders-ms eanders-ms deleted the dev/riknoll/static-blocks branch September 16, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants