Build d.ts for target #10192
Open
Build d.ts for target #10192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eanders-ms
reviewed
Sep 27, 2024
| ); | ||
|
|
||
| console.log(`writing combined.d.ts`) | ||
| fs.writeFileSync(path.join(builtFolder, "combined.d.ts"), combined); |
There was a problem hiding this comment.
If this is a single file for all d.ts, maybe call it index.d.ts?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple version for now since we just want a prototype, but easy to add list of packages to include / from share link support / etc if we want.
Should look at stripping it so hidden / deprecated apis etc are removed as well, but spent too long staring at this before realizing my local arcade build was just very broken so need to look at other stuff that's more useful for now, basically just stashing this here.
it outputs to separate d.ts files but also combines them into a 'combined.d.ts' at the end. This doesn't kick off a build or anything so need to have served first (which does mean it only takes about a second to run
(could also go from program -> more full d.ts emitter, but this seems to work fine for what we want at least?)
generated-dts.zip