Match punctuation for code card descriptions #10221
Conversation
Co-authored-by: Sarah Rietkerk <[email protected]>
| @@ -100,7 +100,13 @@ export function renderCodeCard(card: pxt.CodeCard, options: CodeCardRenderOption | |||
| } | |||
| if (card.description) { | |||
| const descr = div(ct, 'ui description'); | |||
| const shortenedDescription = card.description.split('.')[0] + '.'; | |||
| const regex = /((?:\.{1,3})|[\!\?…])/; | |||
There was a problem hiding this comment.
This is a nice improvement, also somewhat English-centric. Are there additional characters we should consider here to support all languages?
There was a problem hiding this comment.
(totally fine to defer additional character support if it isn't straight forward)
There was a problem hiding this comment.
I'll look at the languages we support in the editor and see what else needs to be added.
There was a problem hiding this comment.
Yea I wasn't able to find a collection of end-of-sentence punctuation for all languages. This would require going through each language one by one. I'm going to defer this work for now.
There was a problem hiding this comment.
if we are concerned about this, we could always only enable this behavior for languages we know it works for and then just use css text-overflow for the rest
There was a problem hiding this comment.
@riknoll How would I do that?
Thanks to @riknoll for all the help.
Fixes https://github.com/microsoft/pxt-minecraft/issues/2508