clean up PageviewPerformanceData tick a bit

[jwunderl]

Here's an example of what the tick looks like when it goes through this fn:

into ->

{
    "name": "Microsoft.ApplicationInsights.{0}.PageviewPerformance",
    "time": "2023-07-12T16:44:43.715Z",
    "iKey": "9801ed01-c40f-46ec-aa40-2a1742a9e71c",
    "ext": {
        "app": {
            "sesId": "{b64ish}"
        },
        "device": {
            "localId": "browser",
            "deviceClass": "Browser"
        },
        "trace": {
            "traceID": "{b16ish}",
            "name": "/75618-11489-17671-85517"
        },
        "user": {
            "id": "{b64ish}"
        }
    },
    "tags": [],
    "data": {
        "duration": 3642.60000000149
    },
    "baseType": "PageviewPerformanceData",
    "baseData": {
        "name": "world_race",
        "uri": "http://localhost:3232/75618-11489-17671-85517",
        "isValid": true,
        "durationMs": 3642.60000000149,
        "duration": "00:00:03.643",
        "perfTotal": "00:00:03.643",
        "networkConnect": "00:00:00.319",
        "sentRequest": "00:00:00.876",
        "receivedResponse": "00:00:00.002",
        "domProcessing": "00:00:02.446"
    },
    "ver": "4.0"
}

end of fn

{
    "name": "Microsoft.ApplicationInsights.{0}.PageviewPerformance",
    "time": "2023-07-12T16:44:43.715Z",
    "iKey": "9801ed01-c40f-46ec-aa40-2a1742a9e71c",
    "ext": {
        "app": {
            "sesId": "{b64ish}"
        },
        "device": {
            "localId": "browser",
            "deviceClass": "Browser"
        },
        "trace": {
            "traceID": "{b16ish}",
            "name": "/xxxxx-xxxxx-xxxxx-xxxxx"
        },
        "user": {
            "id": "{b64ish}"
        }
    },
    "tags": [],
    "data": {
        "duration": 3642.60000000149
    },
    "baseType": "PageviewPerformanceData",
    "baseData": {
        "name": "http://localhost:3232",
        "uri": "http://localhost:3232/xxxxx-xxxxx-xxxxx-xxxxx",
        "isValid": true,
        "durationMs": 3642.60000000149,
        "duration": "00:00:03.643",
        "perfTotal": "00:00:03.643",
        "networkConnect": "00:00:00.319",
        "sentRequest": "00:00:00.876",
        "receivedResponse": "00:00:00.002",
        "domProcessing": "00:00:02.446",
        "properties": {
            "pageName": "world_race",
            "cookie": false
        }
    },
    "ver": "4.0"
}

It looks like these are the ones that are getting specially handled to create the perf data table with non matching names.

[abchatra]

@thsparks probably needs to review as well.

[kimprice]

Why is var used throughout instead of const? I don't see any reassignment.

[jwunderl]

I was just matching the rest of the file since this one's going to be ported to several editors; this one's directly embedded in the page (not ts or anything) so we've historically been pretty cautious of using newfangled javascript features, though I believe we have stopped having to support editors that this would have caused problems in so should be fine to move over to let / const's across the board now (though I'd leave that for a separate pr most likely, just for ease of porting)