Branding: Add Microsoft logo to first loading screen #9605
Conversation
|
Will we still keep the theme colors? i.e. blue for micro:bit and dark grey for minecraft? |
|
@Jaqster great question |
| -webkit-animation: @loaderAnimation @loaderSpeed infinite linear; | ||
| animation: @loaderAnimation @loaderSpeed infinite linear; | ||
| } | ||
|
|
||
| .ui.loader.main.msft:after { | ||
| background: transparent @loaderMsftImage no-repeat center center; | ||
| background-size: 99%; |
There was a problem hiding this comment.
does the 1% here make a difference / what's the change here handling?
There was a problem hiding this comment.
Yea, at 100%, the image is cutoff and zoomed in on the part of the icon.
There was a problem hiding this comment.
Ah okay makes sense, might be worth a quick comment above it so if we run into it again we know why it's special cased a bit~
Co-authored-by: Joey Wunderlich <[email protected]>
|
@kimprice you need to make @loaderAnimation separate, as I understand it, if you override @loaderAnimation, then the animation for the Microsoft logo will be the same as for the project logo. |
microsoft/pxt#9605 Fix overlapping of the Microsoft brand logo and the project logo on the first boot.
Yes, this change is just to change the initial loading screen. All other loading screens will be target-specific. I override the |
* dump-pxt-v9 We raise the version of pxt-core, pxt-common-packages. Field changes. Add search to pxtarget (workspaceSearch). Add missing files. * Update style.less Removing a temporary fix 4017a8b * common-modal-header Restore common-modal-header color in add extension window. * blocks-or-JS-editor-toggle #1016 * fix-brend-logo-and-project-logo-overlay microsoft/pxt#9605 Fix overlapping of the Microsoft brand logo and the project logo on the first boot. * fix-color-editordropdown Fix color editordropdown selection JS or Python. Fix alignment inside dropdown menu. * Update loader.svg Lego cube logo. I drew it myself. * Update loader.svg * Update pxtarget.json Added more options * Update pxtarget.json The python language is translated from experiments. * blocklySearchArea-hide-on-mobile Hide the blocklySearchArea search field on the mobile version of the site. * blocklySearchArea-expanding-horiz blocklySearchArea expanding horizontally. * Update footer.html * blocklyTreeIcon-fontawsome-fix Before that, it was not possible to set the icon font awesome, tick. the font has been reassigned to a different one from Lego. * blocklyFlyoutLabel-fontawsome-fix * blocklyTreeIconfunctions-fontawsome * icons-update For storage and automation. * sizing-fonts-icons Icon sizes in these fonts turned out to be different. Native icons turned out to be smaller than fontawsome. I scaled them, and reduced the overall font size for the icons in the category. * broadcast-extension-changes Change the extension code. Fontawesome icon added. * storage-category-properties-moved * storage-ext-update-color Changed color for storage extension to be different from automation extension. * storage-extension-fix Macros for accessing buffer and string data for storage lib. * Update storage-core.ts The storage-core.ts file has been cleaned up. Sorted and added default values. * Update storage-core.ts * csv-separator-support It is possible to change the csv file separator. * libs-pxt-update * Revert "libs-pxt-update" This reverts commit 60118ef. * brodcast-pxt-update * bump-pxt-9.1.10 * icon-properties-update * removed-margin-to-the-category-btn Removed padding so category button is full height. Removed the commented out css code that displays the button borders. * Update blockly-toolbox.less * blocklySearchArea-margin-top-zero Removed too much margin top.
The following loading screen is displayed on first load for all targets instead of a target-specific icon.
