Do Not Expand Sim After Tutorial in Headless Mode #9644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I considered putting this check inside expandSimulator so it no-oped if we're in headless mode, but I think this may still be used to see the file explorer in javascript mode, so I left that untouched for now.
jwunderl
approved these changes
Aug 18, 2023
thsparks
deleted the
thsparks/minecraft/fix_code_editor_layout_after_tutorial
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a tutorial ends and the user clicks "Done" to go to the main code editor, we were calling into
expandSimulator, which will open the sidebar even when we don't have an actual simulator to show. This change prevents that call if we're in headless mode (i.e. no simulator).I considered putting this check inside
expandSimulatorso it no-oped there if we're in headless mode, but I think this may still be used to see the file explorer in javascript mode, so I left that untouched for now.Fixes https://github.com/microsoft/pxt-minecraft/issues/2323