Add insufficient blocks case to code validation #9647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We don't currently have a separate case for insufficient blocks that are disabled - it'll show the same message. For example: |
jwunderl
approved these changes
Aug 21, 2023
eanders-ms
approved these changes
Aug 21, 2023
thsparks
approved these changes
Aug 21, 2023
| @@ -81,6 +82,9 @@ export class BlocksExistValidator extends CodeValidatorBase { | |||
| } else if (disabledBlocks.length > 0) { | |||
| isValid = false; | |||
| errorDescription = lf("Make sure your blocks are connected to the rest of your code like this."); | |||
| } else if (insufficientBlocks.length > 0) { | |||
| isValid = false; | |||
| errorDescription = lf("Make sure you have enough blocks in your workspace. It should look like this."); | |||
There was a problem hiding this comment.
Since it will send this message if the block exists but is disconnected, perhaps we could rephrase slightly: "Make sure you have enough blocks connected to your workspace. It should look like this.
|
(leaving a note here for other reviewers that we'll be looking at adding other authoring for specifying required blocks vs just from highlighting in a separate pr) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The insufficient blocks case is when the tutorial step requires more than one of the same type of block and the user has at least one of that type of block, but not all of the blocks. For example, in the picture below the user needs two "variables_set" blocks but only has one. Note: this example is a made-up tutorial step as I don't think we have any current tutorials that require more than one block of the same type in a single step.
Joey already added a check for insufficient blocks here: https://github.com/microsoft/pxt/blob/master/pxtblocks/code-validation/validateBlocksExist.ts#L27
This PR just uses that check to create the appropriate code validation message to the user.