Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always sort by relevance when searching projects in script manager #9656

Merged
merged 1 commit into from
Aug 28, 2023

Conversation

riknoll
Copy link
Member

@riknoll riknoll commented Aug 25, 2023

Fixes microsoft/pxt-arcade#6035

Changing the script manager to always sort by relevance if there is any search term entered. It switches back once you delete the search term.

The search results we get back from the webworker are sorted by relevance, but we were completely ignoring that and sorting by name/time instead which is 100% useless.

@riknoll riknoll requested a review from a team August 25, 2023 22:22
@riknoll riknoll merged commit 0053c5f into master Aug 28, 2023
7 checks passed
@riknoll riknoll deleted the fix-project-search branch August 28, 2023 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Project search is useless
2 participants