Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing a few time machine bugs #9697

Merged
merged 3 commits into from
Sep 26, 2023
Merged

Fixing a few time machine bugs #9697

merged 3 commits into from
Sep 26, 2023

Conversation

riknoll
Copy link
Member

@riknoll riknoll commented Sep 26, 2023

Fixes three bugs:

  1. If you shared a script and then immediately opened the history, the share wouldn't show up
  2. There was a minor text bleeding issue in the header on small screens
  3. Sometimes the updateHistory would calculate an extra diff when collapsing history entries: one to check for equality, another to actually push on the stack. I replaced the first one with a simple equality check since that's a much cheaper operation

@riknoll riknoll requested a review from a team September 26, 2023 22:34
@riknoll riknoll merged commit fc52471 into master Sep 26, 2023
7 checks passed
@riknoll riknoll deleted the time-machine-fix branch September 26, 2023 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants