New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tweak toggle simulator settings menu option in headless mode #9730

Merged

riknoll merged 1 commit into master from dev/riknoll/headless-file-explorer

Oct 19, 2023

Member

riknoll commented Oct 19, 2023

Fixes https://github.com/microsoft/pxt-minecraft/issues/2366
Fixes https://github.com/microsoft/pxt-minecraft/issues/2325

Tweaks the simulator collapse toggle when in headless mode so that:

It doesn't show up in blocks
In JavaScript/Python, it says "Toggle the File Explorer" rather than "Toggle the Simulator"
When switching back to blocks the simulator pane automatically collapses if toggled on

This only affects headless mode which is only used by Minecraft.


          tweak toggle simulator settings menu option in headless mode

8a1053a

riknoll requested a review from a team

October 19, 2023 17:34

thsparks approved these changes

View reviewed changes

Contributor

thsparks left a comment

LGTM. Thanks!

riknoll merged commit 4405123 into master

7 checks passed

riknoll deleted the dev/riknoll/headless-file-explorer branch

October 19, 2023 18:14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet