Update Blocks Exist Json Schema for JsonPath Friendliness #9905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thsparks
added a commit
to microsoft/pxt-microbit
that referenced
this pull request
Mar 6, 2024
The structure of the blockCounts input for blocksExist validator plans was not JsonPath friendly, as the customizable blockId was treated as a property and it was also a part of the path for count. This change adjusts the schema so both blockId and count can be referenced more easily by JsonPath, which we will need for parameterized criteria. Depends on microsoft/pxt#9905.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The structure of the
blockCountsinput forblocksExistvalidator plans was not JsonPath friendly, as the customizableblockIdwas treated as a property and it was also a part of the path for count. This change adjusts the schema so bothblockIdandcountcan be referenced more easily by JsonPath, which we will need for parameterized criteria.No user-facing functionality changes.