Several Blockly fixes #9939

riknoll · 2024-03-26T21:31:16Z

Several fixes of new-blockly regressions:

quotes are now red again
text blocks now have default parameters again (this was actually a bug in our old Blockly code, but I brought the default values back to mimic the old buggy behavior)
adds a light contrasting outline for dark shadow blocks
removes references to inDebugWorkspace, which is a method that no longer exists
restores the old behavior of the slider field where it grabbed the track color from the parent block

I want to add a new test runner for our toolbox block XML generating code, but I'll do that in a separate PR

riknoll added 5 commits March 26, 2024 13:28

restore red color of block quotes

7f4cf51

bring back default paramter for text blocks

3a7c072

bring back light outline for dark shadow blocks

d3a1683

remove references to inDebugWorkspace

ddad4ca

get field slider track color from the parent block

04e5ebd

riknoll requested a review from a team March 26, 2024 21:31

thsparks approved these changes Mar 26, 2024

View reviewed changes

riknoll merged commit 5c1b517 into master Mar 26, 2024
6 checks passed

riknoll deleted the dev/riknoll/mb-block-fixes branch March 26, 2024 21:56

Provide feedback