Improved handling of __getitem__, __setitem__ and __delitem__ m…

…agic method modeling to handle descriptor objects. This addresses #9653. (#9654)
microsoft · Jan 3, 2025 · a254b79 · a254b79
1 parent a03e8e4
commit a254b79
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/packages/pyright-internal/src/analyzer/typeEvaluator.ts b/packages/pyright-internal/src/analyzer/typeEvaluator.ts
@@ -7494,7 +7494,9 @@ export function createTypeEvaluator(
                     ) {
                         const itemMethodType = getBoundMagicMethod(
                             concreteSubtype,
-                            getIndexAccessMagicMethodName(usage)
+                            getIndexAccessMagicMethodName(usage),
+                            /* selfType */ undefined,
+                            node.d.leftExpr
                         );
 
                         if ((flags & EvalFlags.TypeExpression) !== 0) {
@@ -7844,7 +7846,7 @@ export function createTypeEvaluator(
         }
 
         const magicMethodName = getIndexAccessMagicMethodName(usage);
-        const itemMethodType = getBoundMagicMethod(baseType, magicMethodName, selfType);
+        const itemMethodType = getBoundMagicMethod(baseType, magicMethodName, selfType, node.d.leftExpr);
 
         if (!itemMethodType) {
             addDiagnostic(