Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Durr hoyer library min and max #1936

Closed
wants to merge 16 commits into from
Closed

Durr hoyer library min and max #1936

wants to merge 16 commits into from

Commits on Sep 25, 2024

  1. refactors searching pattern as python build.py was throwing error unt… 

    …il fix was implemented, takes advantage of optimized slice pattern matching native to rust
    @mertall
    mertall committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    c320532 View commit details
    Browse the repository at this point in the history

  2. initial version of min max of durr hoyer algorithm, issues with DrawR… 

    …andomInt(), reference microsoft#1928
    @mertall
    mertall committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    3d7722f View commit details
    Browse the repository at this point in the history

  3. adds finding max testing

    @mertall
    mertall committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    6b339de View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2024

  1. Update imports to match other pattern for other Std files 

    Co-authored-by: Manvi-Agrawal <[email protected]>
    @mertall @Manvi-Agrawal
    mertall and Manvi-Agrawal authored Sep 26, 2024
    Configuration menu
    Copy the full SHA
    c16fa6d View commit details
    Browse the repository at this point in the history

  2. removes unecessary imports and moves Random generation outside of Std… 

    … folder
    @mertall
    mertall committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    77a1f95 View commit details
    Browse the repository at this point in the history

  3. fixes imports for tests and addresses redundant logic, renaming vars … 

    …for max test case
    @mertall
    mertall committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    96e5f87 View commit details
    Browse the repository at this point in the history

  4. seperates common logic out of unit tests for findng max and min, corr… 

    …ects the expectedMaxaindices variable
    @mertall
    mertall committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    1f17e43 View commit details
    Browse the repository at this point in the history

  5. adds required summary annotations to all operations/functions

    @mertall
    mertall committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    ea88f5f View commit details
    Browse the repository at this point in the history

  6. reverts back to older commit, functionality of 50% accuracy was lost.… 

    … reopening closed suggestions
    @mertall
    mertall committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    d6949d0 View commit details
    Browse the repository at this point in the history

  7. fixes testing file

    @mertall
    mertall committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    7951452 View commit details
    Browse the repository at this point in the history

  8. changes requested implemented

    @mertall
    mertall committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    e0259fe View commit details
    Browse the repository at this point in the history

  9. adds unit tests for 0 in list, updates algorithm

    @mertall
    mertall committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    689e346 View commit details
    Browse the repository at this point in the history

  10. fixes typo for betterCandidateFound

    @mertall
    mertall committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    0ab0fba View commit details
    Browse the repository at this point in the history

  11. formatting

    @mertall
    mertall committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    9c1013e View commit details
    Browse the repository at this point in the history

  12. formatting for test operation and removes redundant test

    @mertall
    mertall committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    1d55cfb View commit details
    Browse the repository at this point in the history

  13. updates testing suite, code is exectuable now, but rust script cannot… 

    … find the DurrHoyerAlgorithm
    @mertall
    mertall committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    651886a View commit details
    Browse the repository at this point in the history