Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document Image API completion #2111

Closed
8 of 13 tasks
kikisaints opened this issue Mar 4, 2019 · 4 comments
Closed
8 of 13 tasks

Document Image API completion #2111

kikisaints opened this issue Mar 4, 2019 · 4 comments

Comments

@kikisaints
Copy link
Contributor

kikisaints commented Mar 4, 2019

The following unchecked properties are needed to complete the Image control integration into RNWCPP.

P1

  • resizeMode - partial
    Partially supported by Image. This guy is an Enum:
    -cover: Maps to Image.Stretch.UniformToFill
    -contain: Maps to Image.Stretch.Uniform
    -stretch: Maps to Image.Stretch.Fill
    -repeat: Not directly supported by Image. Would need to manually repeat, either by creating multiple XAML elements (eg a Grid of Images), or by dropping down to Composition (say, by using XCBB and creating a tiling Composition EffectBrush with a LoadedImageSurface as the input)
    -center: Not directly supported by Image. Would need to manually center/scale to fit, either in XAML (say, by computing a Brush transform) or by dropping down to Composition (similar to repeat)
  • onError
    Maps to Image.ImageFailed
  • onLoadEnd
    Not directly supported by Image, hook up to Image.ImageOpened/ImageFailed
  • onLoadStart
    Not directly supported by Image, hook up underlying BitmapImage.DownloadProgress

P2

  • blurRadius Image blurRadius #2631
    Not directly supported by Image element. Would need to drop down the Composition for this. One possible proposal (using RS2 APIs):
    -Create a XamlCompositionBrushBbase and use this to fill the background of a Panel (eg Canvas)
    -The XCBB would create a Composition EffectBrush for the blur, and a LoadedImageSurface as the input.
  • defaultSource Image defaultSource #2632
    A static image to display while loading the image source.
    Not directly supported by Image. Would need to manually load/display this, similar to loadingIndicatorSource.
  • loadingIndicatorSource Image loadingIndicatorSource #2633
    Similarly to source, this property represents the resource used to render the loading indicator for the image, displayed until image is ready to be displayed, typically after when it got downloaded from network.
    Not directly supported by Image. Would need to manually load/display the loading indicator image and switch to the real image when it's ready. There is likely open-source code for this that could be borrowed.
  • fadeDuration Image fadeDuration #2634

P3

Already Completed

  • source
  • onLayout
  • onLoad
Future
  • resizeMethod Android Only
  • accessible iOS Only
  • capInsets iOS Only
  • onPartialLoad iOS Only
  • onProgress iOS Only
@chrisglein
Copy link
Member

Tracking progress in this is now handled in this project board: https://github.com/microsoft/react-native-windows/projects/18
@kikisaints can you move the API status of this to markdown, similar to #2113?

@kikisaints
Copy link
Contributor Author

@chrisglein what parts were you thinking needed to be documented?

@chrisglein
Copy link
Member

Status of implementation, vnext vs. current, issue tracking for pending implementations, justification for anything "won't fix".
Sync with @SavoySchuler and @harinikmsft as we have a couple of these we want to go after. Savoy was going to take a crack at establishing the pattern.

@chrisglein chrisglein changed the title [Component] Image - Property Completion Document Image API completion Oct 29, 2019
@chrisglein chrisglein removed this from the MVP (vNext M4) milestone Jan 21, 2020
@chrisglein chrisglein removed the vnext label Mar 18, 2020
@ghost ghost added the Invalid Triage https://github.com/microsoft/react-native-windows/wiki/Triage-Process (label applied by bot) label Apr 9, 2020
@chrisglein chrisglein added this to the Backlog milestone Jul 17, 2020
@chrisglein chrisglein removed the Invalid Triage https://github.com/microsoft/react-native-windows/wiki/Triage-Process (label applied by bot) label Jul 17, 2020
@ghost ghost added the Invalid Triage https://github.com/microsoft/react-native-windows/wiki/Triage-Process (label applied by bot) label Sep 17, 2020
@chrisglein
Copy link
Member

All missing APIs are tracked with issues or on the board. We have no immediate plans to create formal per-method API parity documentation, so closing this issue.

@jonthysell jonthysell removed the Invalid Triage https://github.com/microsoft/react-native-windows/wiki/Triage-Process (label applied by bot) label Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants